Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CDN for Twemoji images from default to jsDelivr #321

Merged
merged 3 commits into from
Nov 19, 2022

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Nov 19, 2022

Related: #320

MaxCDN, Twemoji's default CDN, will shut down at December 31, 2022.
https://www.stackpath.com/blog/maxcdn-and-securecdn-are-retiring-heres-what-it-means-for-you

I had expected the change of default base path in next release of Twemoji, but no longer expected continuous update due to contributor's lay-off and chaos around acquired Twitter.

This PR makes the change to use jsDelivr CDN to provide twemoji images, unless there is specified base path in emoji.twemoji.base constructor option.

// Use Twemoji via jsDelivr
const marp = new Marp();
marp.render(':+1:') // https://cdn.jsdelivr.net/gh/twitter/twemoji@14.0.2/assets/svg/1f44d.svg

// Use Twemoji via the default CDN (MaxCDN)
const marp = new Marp({
  emoji: {
    twemoji: { base: undefined }
  }
})
marp.render(':+1:') // https://twemoji.maxcdn.com/v/14.0.2/svg/1f44d.svg

@yhatt yhatt merged commit 1227c81 into main Nov 19, 2022
@yhatt yhatt deleted the update-twemoji-cdn branch November 19, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant