Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support absolute path for extra theme #110

Closed
melck opened this issue Dec 5, 2019 · 3 comments
Closed

Support absolute path for extra theme #110

melck opened this issue Dec 5, 2019 · 3 comments

Comments

@melck
Copy link

melck commented Dec 5, 2019

I have tried this option "markdown.marp.themes" and like it is described, it only work with relative css file in workspace or url.

I want to have a external folder with multiple themes. Do you think u could support absolute path for that ?

@yhatt
Copy link
Member

yhatt commented Dec 5, 2019

Our resolution rule is following as same as VS Code's markdown.styles rule. Unfortunately we have not thought absolute path support for markdown.marp.themes because there is potential security risk by a malicious workspace.

Refer to microsoft/vscode#45260 (comment).

@melck
Copy link
Author

melck commented Dec 8, 2019

Thanks for information 😢. I understand why, but it's not really simple for external theme with image, etc.

@yhatt
Copy link
Member

yhatt commented Dec 8, 2019

Sometimes we have to take an inconvenience for users safe. 😗

You can take some workarounds:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants