Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The previewed slide page keeps jumpping when I edit the markdown document #248

Closed
RocStone opened this issue Jun 7, 2021 · 5 comments · Fixed by #252
Closed

The previewed slide page keeps jumpping when I edit the markdown document #248

RocStone opened this issue Jun 7, 2021 · 5 comments · Fixed by #252
Labels
bug Something isn't working upstream Depended on upstream

Comments

@RocStone
Copy link

RocStone commented Jun 7, 2021

The previewed page will jump up when I hit the backspace key.
@yhatt
Copy link
Member

yhatt commented Jun 7, 2021

Marp is not almost involved in preview sync so it may be a bug of VS Code. Reporting to VS Code repository would be good.

Related: microsoft/vscode#69467

@yhatt yhatt added the bug Something isn't working label Jun 7, 2021
@RocStone
Copy link
Author

RocStone commented Jun 8, 2021

After I commented all of the images and switched to the native preview of vscode, the preview doesn't jump when I was editing.
However, when I switch to the marp preview, it jumps.

Peek 2021-06-08 13-35

@RocStone
Copy link
Author

RocStone commented Jun 8, 2021

This video might be even more clear
Peek 2021-06-08 13-57

@yhatt
Copy link
Member

yhatt commented Jun 8, 2021

After I commented all of the images and switched to the native preview of vscode, the preview doesn't jump when I was editing.

Looks like still jumping slightly even in the native preview so I guess there is a root cause in VS Code, not Marp. Could you report to VS Code repository?

@yhatt yhatt added the upstream Depended on upstream label Jun 8, 2021
This was referenced Jun 11, 2021
Closed
Merged
Closed
@yhatt
Copy link
Member

yhatt commented Jun 18, 2021

I've made a patch in #252 but it is potentially dangerous hack and we don't want to apply if possible. I've reported details into VS Code in microsoft/vscode#126640 so please track the progress of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working upstream Depended on upstream
Projects
None yet
Milestone
No milestone
2 participants
@yhatt @RocStone