Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for readability #140

Merged
merged 20 commits into from Aug 22, 2021
Merged

Update documentation for readability #140

merged 20 commits into from Aug 22, 2021

Conversation

zhangchuck
Copy link
Contributor

@zhangchuck zhangchuck commented Aug 1, 2021

Goal:

Update documentation for clarity.

Process:

  • Using the Grammarly service to do automatic fixes, and then doing a human proofread for the entire document.
  • I'll work my way through everything in the website/docs/ folder.

Status:

  • /guide/
    • directives.md
    • fitting-header.md
    • fragmented-list.md
    • heading-divider.md
    • how-to-write-slides.md
    • image-syntax.md
    • math-typesetting.md
    • theme.md
  • /introduction/
    • install.md
    • whats-marp.md
  • /tools/ (just stubs at the moment)
    • marp-cli.md
    • marp-for-vs-code.md

@zhangchuck
Copy link
Contributor Author

@yhatt Not sure if this would be helpful, but I thought it might be good to do a proofread of all the documentation (e.g., using Grammarly) to clean up typos and make the documentation a bit easier to use. I did one page (directives) as an example. Let me know if you'd prefer to do this yourself or you don't think this is helpful to the project.

Thanks, and appreciate all your work on this framework!

@yhatt
Copy link
Member

yhatt commented Aug 1, 2021

Thanks for your contribution 😍

I'm not native so already have relied to Google & DeepL translator (and partially Grammarly: I rarely use because I felt its compatibillity with Markdown is not good) for checking accuracy of writing. When the result of translator from English to native language is covenying my intention exactly, I sometimes take it even if used a poor grammar.

There are still many stubs in the unified docs, and I would likely to write more sections with many mistakes in a grammar. I welcome to contributions for proofreading anytime!

@yhatt
Copy link
Member

yhatt commented Aug 1, 2021

@zhangchuck
Copy link
Contributor Author

Happy to help. I'll slowly work my through the existing docs (I listed them in the draft PR) and will mark this for review once I've gone through all of them.

Copy link
Member

@yhatt yhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick look for introdocution pages

website/docs/introduction/install.md Outdated Show resolved Hide resolved
website/docs/introduction/whats-marp.md Outdated Show resolved Hide resolved
website/docs/introduction/install.md Outdated Show resolved Hide resolved
website/docs/guide/fragmented-list.md Outdated Show resolved Hide resolved
website/docs/introduction/install.md Outdated Show resolved Hide resolved
@zhangchuck zhangchuck marked this pull request as ready for review August 19, 2021 05:45
@yhatt
Copy link
Member

yhatt commented Aug 20, 2021

@zhangchuck Marp team is planning to change the structure of documentation about image syntax from Marpit framework drastically. By containing 2e981bc, this PR may bloat and late to merge. Please consider to revert updates for image-syntax.md and split into another pull request.

@zhangchuck
Copy link
Contributor Author

Okay, I've reverted those changes back to the original file (i.e., just the stub).

@yhatt
Copy link
Member

yhatt commented Aug 21, 2021

https://github.com/marp-team/marp/runs/3388494059
Please run yarn format:write on the root to apply formatting.

.github/dependabot.yml 46ms
.github/workflows/test.yml 24ms
.pnp.cjs 3897ms
.yarn/releases/yarn-berry.cjs 5442ms
.yarnrc.yml 8ms
package-lock.json 8ms
package.json 6ms
README.md 99ms
tsconfig.json 5ms
website/.eslintrc.js 7ms
website/assets.d.ts 279ms
website/babel.config.js 8ms
website/blog/marp-for-vs-code-v1.md 114ms
website/blog/marpit-v2-marp-core-v2-and-marp-cli-v1.md 57ms
website/blog/re-creation-of-marp-website.md 35ms
website/blog/the-story-of-marp-next.md 209ms
website/components/blog/BlogHeader.tsx 92ms
website/components/Button.tsx 37ms
website/components/CodeBlock.tsx 74ms
website/components/docs/Breadcrumb.tsx 35ms
website/components/docs/Layout.tsx 22ms
website/components/docs/layouts/Desktop.tsx 53ms
website/components/docs/layouts/Mobile.tsx 80ms
website/components/docs/Navigation.tsx 25ms
website/components/Footer.tsx 12ms
website/components/Header.tsx 51ms
website/components/Layout.tsx 38ms
website/components/markdown/Anchor.tsx 7ms
website/components/markdown/Heading.tsx 51ms
website/components/markdown/Pre.tsx 12ms
website/components/Marp.tsx 62ms
website/components/ScrollToTop.tsx 21ms
website/components/Title.tsx 11ms
website/components/top/Description.tsx 19ms
website/components/top/Features.tsx 56ms
website/components/top/GetStarted.tsx 49ms
website/components/top/Hero.tsx 13ms
website/components/Typography.tsx 32ms
website/css/index.css 13ms
website/css/plugin-rem.js 9ms
website/docs/guide/directives.md 135ms
website/docs/guide/fitting-header.md 22ms
website/docs/guide/fragmented-list.md 16ms
website/docs/guide/heading-divider.md 29ms
website/docs/guide/how-to-write-slides.md 29ms
website/docs/guide/image-syntax.md 11ms
website/docs/guide/math-typesetting.md 63ms
website/docs/guide/theme.md 3ms
website/docs/introduction/install.md 45ms
website/docs/introduction/whats-marp.md 31ms
website/docs/manifest.yaml 10ms
website/docs/tools/marp-cli.md 3ms
website/docs/tools/marp-for-vs-code.md 3ms
website/global.d.ts 4ms
website/next-env.d.ts 4ms
website/next.config.js 13ms
website/package.json 6ms
website/pages/_app.tsx 15ms
website/pages/_document.tsx 8ms
website/pages/404.tsx 14ms
website/pages/blog.tsx 53ms
website/pages/blog/[slug].tsx 31ms
website/pages/docs/[[...slug]].tsx 79ms
website/pages/index.tsx 13ms
website/postcss.config.js 5ms
website/tailwind.config.js 15ms
website/tsconfig.json 12ms
website/utils/date.ts 10ms
website/utils/hooks/useFontFace.tsx 20ms
website/utils/markdown/index.tsx 11ms
website/utils/markdown/parse/image-paragrpah-to-figure.ts 16ms
website/utils/markdown/parse/index.ts 8ms
website/utils/markdown/parse/marp-code-block.ts 8ms
website/utils/markdown/renderer/index.ts 12ms
website/utils/markdown/renderer/sanitize.ts 5ms
website/utils/title.ts 4ms
website/utils/url.ts 5ms
@zhangchuck
Copy link
Contributor Author

Not familiar with the Node (?) ecosystem. I ended up installing and running prettier, i.e

yarn prettier --write .

Copy link
Member

@yhatt yhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems for this PR.

@yhatt yhatt merged commit 921b20b into marp-team:main Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants