Inherit all attributes into the section element inside pseudo layer for advanced background #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marpit's advanced background generates 3 isolated layers for rendering advanced background images, slide contents, and generated contents by pseudo-class
::before::after, such as a pagination.The last layer we are calling "Psuedo layer" has only inherited selected attributes from the original
sectionelement. It brings no inheritance of the attribute for style scopingdata-marpit-scope-XXXXXXXX, so styling to paginationsection::aftervia<style scoped>has been ignored.In this PR I've changed to inherit all attributes from the original
sectionelement into the pseudo layer. It might bring a broken style in a few cases, but I expect there is no major problem because the layer for advanced backgrounds that is working with the same inheritance logic is stable until now.Fix #328.
Related: marp-team/marp#287