Use the IN operator for recommender filter with structured indexes #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanliAlex
requested changes
May 6, 2024
| @@ -202,8 +202,11 @@ def _get_default_interpolation_method(self, marqo_index: MarqoIndex) -> Interpol | |||
| else: | |||
| return InterpolationMethod.LERP | |||
|
|
|||
| def _get_exclusion_filter(self, documents: List[str], user_filter: Optional[str]) -> str: | |||
| not_in = 'NOT (' + ' OR '.join([f'_id:({doc})' for doc in documents]) + ')' | |||
| def _get_exclusion_filter(self, marqo_index: MarqoIndex, documents: List[str], user_filter: Optional[str]) -> str: | |||
There was a problem hiding this comment.
Do we need a small test on this to track the divergence between structured and unstructured indexes?
wanliAlex
approved these changes
May 7, 2024
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
For structured indexes, use the IN operator for recommender input document exclusion
What is the current behavior? (You can also link to an open issue here)
Conjunction of OR operators. From experience we know this is prone to SO errors in Vespa due to a Vespa bug
What is the new behavior (if this is a feature change)?
Use the safer IN operator if index is structured
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Have unit tests been run against this PR? (Has there also been any additional testing?)
Related Python client changes (link commit/PR here)
Related documentation changes (link commit/PR here)
Other information:
Please check if the PR fulfills these requirements