Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change highlights log message level to DEBUG #837

Merged
merged 1 commit into from
May 15, 2024

Conversation

farshidz
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Improvement

  • What is the current behavior? (You can also link to an open issue here)
    Where attributes_to_retrieve excludes a searchable attribute, Marqo prints a warning because retrieved fields aren't enough to generate highlights. This warning is per result, so for limit=1000 it's printed 1000 times. In production, this has led to high CPU util and 1s+ post-processing telemetry (i.e. result processing in Marqo).

  • What is the new behavior (if this is a feature change)?
    Change log level to DEBUG for this message

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    NA

  • Related Python client changes (link commit/PR here)
    NA

  • Related documentation changes (link commit/PR here)
    NA

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@farshidz farshidz merged commit 5f1568a into mainline May 15, 2024
38 of 43 checks passed
@farshidz farshidz deleted the farshid/highlight-warning-level branch May 15, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants