Implement Map Type Score modifiers and long/double split #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
requested changes
Jun 24, 2024
src/marqo/core/unstructured_vespa_index/unstructured_document.py
Outdated
Show resolved
Hide resolved
farshidz
requested changes
Jun 24, 2024
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
farshidz
previously approved these changes
Jun 24, 2024
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
approved these changes
Jun 24, 2024
3 tasks
RaynorChavez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Currently structured and unstructured indexes don't support score modifiers stored in dict fields.
And all ints are converted to floats. We lose accuracy on large ints.
What is the new behavior (if this is a feature change)?
In this feature, we implement support for dict score modifiers stored as fields. The subfields are accessed in the search api through dot notation. We support
map<text, int>,map<text, long>,map<text, float>,map<text, double>.We also separately store int values in int8 data types, and long, float, and double are converted into double.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Have unit tests been run against this PR? (Has there also been any additional testing?)
Yes
Related Python client changes (link commit/PR here)
None
Related documentation changes (link commit/PR here)
marqodocs previews/2.9
Other information:
Please check if the PR fulfills these requirements