Skip to content

Commit

Permalink
Remove redistributed KDTree, and make scipy a hard requirement (#438)
Browse files Browse the repository at this point in the history
* Remove redistributed KDTree, and make scipy a hard requirement

Fixes #437

* Remove the "maybe scipy?" thing from CI
  • Loading branch information
pckroon committed Jul 4, 2022
1 parent f283f1a commit e6f16e1
Show file tree
Hide file tree
Showing 8 changed files with 4 additions and 1,107 deletions.
10 changes: 1 addition & 9 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,13 @@ jobs:
include:
- py_version: "3.6"
WITH_CODECOV: true
WITH_SCIPY: true
- py_version: "3.7"
WITH_CODECOV: true
WITH_SCIPY: true
- py_version: "3.8"
WITH_CODECOV: true
WITH_SCIPY: true
- py_version: "3.9"
WITH_CODECOV: true
WITH_SCIPY: false


steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.py_version }}
Expand All @@ -44,10 +40,6 @@ jobs:
run: |
sudo apt-get install dssp
pip install --upgrade setuptools pip
- if: ${{ matrix.WITH_SCIPY }}
name: Install scipy
run: |
pip install scipy
- name: Install package and requirements
run: |
pip install --upgrade .
Expand Down
12 changes: 1 addition & 11 deletions .github/workflows/run_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,23 +25,17 @@ jobs:
include:
- py_version: "3.6"
WITH_CODECOV: true
WITH_SCIPY: true
- py_version: "3.7"
WITH_CODECOV: true
WITH_SCIPY: true
- py_version: "3.8"
WITH_CODECOV: true
WITH_SCIPY: true
- py_version: "3.9"
WITH_CODECOV: true
WITH_SCIPY: false
- py_version: "3.8-dev"
WITH_CODECOV: true
WITH_SCIPY: true
- py_version: "3.9-dev"
WITH_CODECOV: true
WITH_SCIPY: true


steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.py_version }}
Expand All @@ -52,10 +46,6 @@ jobs:
run: |
sudo apt-get install dssp
pip install --upgrade setuptools pip
- if: ${{ matrix.WITH_SCIPY }}
name: Install scipy
run: |
pip install scipy
- name: Install package and requirements
run: |
pip install --upgrade .
Expand Down
5 changes: 1 addition & 4 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,8 @@ install-requires = # ?? requires-dist?
pbr
numpy
networkx ~= 2.0
zip-safe = False

[options.extras_require]
full =
scipy
zip-safe = False

[build_sphinx]
source-dir = doc/source
Expand Down
7 changes: 1 addition & 6 deletions vermouth/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,7 @@

del pbr

try:
from scipy.spatial import cKDTree as KDTree
except ImportError:
LOGGER.info('Using redistributed KDTree. Some functionality might be slow.'
' Install scipy for better performance.', type='performance')
from .redistributed.kdtree import KDTree
from scipy.spatial import cKDTree as KDTree

del LOGGER

Expand Down
35 changes: 0 additions & 35 deletions vermouth/redistributed/LICENSE

This file was deleted.

13 changes: 0 additions & 13 deletions vermouth/redistributed/__init__.py

This file was deleted.

0 comments on commit e6f16e1

Please sign in to comment.