Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate use of StopIteration in generators. #28

Closed
amcgregor opened this issue Mar 6, 2019 · 1 comment
Closed

Eliminate use of StopIteration in generators. #28

amcgregor opened this issue Mar 6, 2019 · 1 comment
Assignees
@amcgregor
Labels
1.bug area:translation
Milestone
Kangchenjunga (Bu...

Comments

@amcgregor
Copy link
Member

Python 3.7 has removed this as an acceptable behaviour, as such, cinje breaks on Python 3.7 as demonstrated after adding 3.7 to the Travis-CI test rig, and exploring explosions locally (which are either hilariously non-existent or egregiously verbose exception chains).
@amcgregor amcgregor self-assigned this Mar 6, 2019
amcgregor added a commit that referenced this issue Mar 6, 2019
@amcgregor
Work on #28, armour against StopIteration usage in generators.
d8df370
@amcgregor
Copy link
Member Author

d8df370 corrected the issue by armouring calls to Lines.next() in try/except StopIteration: return blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amcgregor amcgregor

Labels
1.bug area:translation
Projects
None yet
Milestone
Kangchenjunga (Bugfix Release, 1.1.2)
Development

No branches or pull requests
1 participant
@amcgregor