Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal support. #23

Merged
merged 4 commits into from
Nov 30, 2016
Merged

Decimal support. #23

merged 4 commits into from
Nov 30, 2016

Conversation

amcgregor
Copy link
Member

Now that MongoDB 3.4 is out (yay!) we need to add support for Decimal128. This does that.

Note that this field is conditional on having PyMongo 3.4 or later; Marrow Mongo still only requires 3.2. Attempts to from marrow.mongo.field import Decimal on an earlier version will result in a VersionConflict exception.

(To see how this type of conditional field is done, check the setup.py entry points and extras require.)

@amcgregor amcgregor added the 2.enhancement New ideas or improvements. label Nov 30, 2016
@amcgregor amcgregor added this to the 1.1.1 Release milestone Nov 30, 2016
@amcgregor amcgregor self-assigned this Nov 30, 2016
@codecov-io
Copy link

codecov-io commented Nov 30, 2016

Current coverage is 100% (diff: 100%)

Merging #23 into develop will not change coverage

@@           develop    #23   diff @@
=====================================
  Files           21     21          
  Lines         1153   1168    +15   
  Methods          0      0          
  Messages         0      0          
  Branches         0      0          
=====================================
+ Hits          1153   1168    +15   
  Misses           0      0          
  Partials         0      0          

Powered by Codecov. Last update 7a9635a...a20dab5

@amcgregor amcgregor merged commit 2cb1635 into develop Nov 30, 2016
@amcgregor amcgregor deleted the feature/decimal branch December 4, 2016 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.enhancement New ideas or improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants