[Ray] Fix flaky test test_optional_supervisor_node (#3133)

mars-project · Jun 10, 2022 · 221e4b3 · 221e4b3
1 parent e872208
commit 221e4b3
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 32 deletions.
diff --git a/mars/deploy/oscar/tests/test_ray.py b/mars/deploy/oscar/tests/test_ray.py
@@ -187,38 +187,6 @@ def _sync_web_session_test(web_address):
     return True
 
 
-@require_ray
-@pytest.mark.parametrize(
-    "test_option",
-    [
-        [True, 0, ["ray://test_cluster/1/0", "ray://test_cluster/2/0"]],
-        [False, 0, ["ray://test_cluster/0/1", "ray://test_cluster/1/0"]],
-        [True, 2, ["ray://test_cluster/1/0", "ray://test_cluster/2/0"]],
-        [False, 5, ["ray://test_cluster/0/6", "ray://test_cluster/1/0"]],
-    ],
-)
-@pytest.mark.asyncio
-async def test_optional_supervisor_node(ray_start_regular_shared, test_option):
-    import logging
-
-    logging.basicConfig(level=logging.INFO)
-    supervisor_standalone, supervisor_sub_pool_num, worker_addresses = test_option
-    config = _load_config()
-    config["cluster"]["ray"]["supervisor"]["standalone"] = supervisor_standalone
-    config["cluster"]["ray"]["supervisor"]["sub_pool_num"] = supervisor_sub_pool_num
-    client = await new_cluster(
-        "test_cluster",
-        supervisor_mem=1 * 1024**3,
-        worker_num=2,
-        worker_cpu=2,
-        worker_mem=1 * 1024**3,
-        config=config,
-    )
-    async with client:
-        assert client.address == "ray://test_cluster/0/0"
-        assert client._cluster._worker_addresses == worker_addresses
-
-
 @require_ray
 @pytest.mark.parametrize(
     "config",

diff --git a/mars/deploy/oscar/tests/test_ray_cluster_standalone.py b/mars/deploy/oscar/tests/test_ray_cluster_standalone.py
@@ -12,14 +12,18 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+import pytest
 import mars
+
 from .... import tensor as mt
 from .... import dataframe as md
 from ....tests.core import require_ray
 from ....utils import lazy_import
 from ..ray import (
     new_cluster_in_ray,
     new_ray_session,
+    _load_config,
+    new_cluster,
 )
 
 ray = lazy_import("ray")
@@ -64,3 +68,35 @@ def new_ray_session_test():
 
     gc.collect()
     mars.execute(mt.random.RandomState(0).rand(100, 5).sum())
+
+
+@require_ray
+@pytest.mark.parametrize(
+    "test_option",
+    [
+        [True, 0, ["ray://test_cluster/1/0", "ray://test_cluster/2/0"]],
+        [False, 0, ["ray://test_cluster/0/1", "ray://test_cluster/1/0"]],
+        [True, 2, ["ray://test_cluster/1/0", "ray://test_cluster/2/0"]],
+        [False, 5, ["ray://test_cluster/0/6", "ray://test_cluster/1/0"]],
+    ],
+)
+@pytest.mark.asyncio
+async def test_optional_supervisor_node(ray_start_regular, test_option):
+    import logging
+
+    logging.basicConfig(level=logging.INFO)
+    supervisor_standalone, supervisor_sub_pool_num, worker_addresses = test_option
+    config = _load_config()
+    config["cluster"]["ray"]["supervisor"]["standalone"] = supervisor_standalone
+    config["cluster"]["ray"]["supervisor"]["sub_pool_num"] = supervisor_sub_pool_num
+    client = await new_cluster(
+        "test_cluster",
+        supervisor_mem=1 * 1024**3,
+        worker_num=2,
+        worker_cpu=2,
+        worker_mem=1 * 1024**3,
+        config=config,
+    )
+    async with client:
+        assert client.address == "ray://test_cluster/0/0"
+        assert client._cluster._worker_addresses == worker_addresses