Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] df.loc[:, [fields]] triggered unnecessary iterative tiling #2684

Closed
qinxuye opened this issue Feb 8, 2022 · 0 comments · Fixed by #2685
Closed

[BUG] df.loc[:, [fields]] triggered unnecessary iterative tiling #2684

qinxuye opened this issue Feb 8, 2022 · 0 comments · Fixed by #2685
Assignees
@qinxuye
Labels
mod: dataframe task: medium type: bug Something isn't working
Projects
DataFrame v0.9 Release
Milestone
v0.9.0b1

Comments

@qinxuye
Copy link
Collaborator

qinxuye commented Feb 8, 2022

Describe the bug

df.loc[:, [fields]] triggered unnecessary iterative tiling.

To Reproduce
To help us reproducing this bug, please provide information below:

  1. Your Python version
  2. The version of Mars you use
  3. Versions of crucial packages, such as numpy, scipy and pandas
  4. Full stack of the error.
  5. Minimized code to reproduce the error.
from mars.core import tile

df2 = df[df['x'] < 1]
loc_df = df2.loc[:, ['y', 'x']]
tiled_loc_df = tile(loc_df)  # cannot run
@qinxuye qinxuye added this to the v0.9.0b1 milestone Feb 8, 2022
@qinxuye qinxuye added this to To do in DataFrame via automation Feb 8, 2022
@qinxuye qinxuye self-assigned this Feb 8, 2022
@qinxuye qinxuye added this to Issue-Needs prioritizing in v0.9 Release via automation Feb 8, 2022
@qinxuye qinxuye moved this from Issue-Needs prioritizing to Issue-P1 in v0.9 Release Feb 8, 2022
@qinxuye qinxuye mentioned this issue Feb 8, 2022
Merged
2 tasks
@wjsi wjsi closed this as completed in #2685 Feb 9, 2022
DataFrame automation moved this from To do to Done Feb 9, 2022
v0.9 Release automation moved this from Issue-P1 to PR-Done Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qinxuye qinxuye

Labels
mod: dataframe task: medium type: bug Something isn't working
Projects
DataFrame
  
Done
v0.9 Release
PR-Done
Milestone
v0.9.0b1
Development

Successfully merging a pull request may close this issue.

Avoid iterative tiling for df.loc[:, fields] qinxuye/mars
1 participant
@qinxuye