Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid iterative tiling for df.loc[:, fields] #2685

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Avoid iterative tiling for df.loc[:, fields] #2685

merged 1 commit into from
Feb 9, 2022

Conversation

qinxuye
Copy link
Collaborator

@qinxuye qinxuye commented Feb 8, 2022

What do these changes do?

After this PR, iterative tiling is avoided for df.loc[:, fields].

Related issue number

Fixes #2684 .

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@qinxuye qinxuye added type: bug Something isn't working mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels Feb 8, 2022
@qinxuye qinxuye added this to the v0.9.0b1 milestone Feb 8, 2022
@qinxuye qinxuye added this to In progress in DataFrame via automation Feb 8, 2022
@qinxuye qinxuye added this to PR-In progress in v0.9 Release via automation Feb 8, 2022
hekaisheng
hekaisheng approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DataFrame automation moved this from In progress to Reviewer approved Feb 9, 2022
wjsi
wjsi approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjsi wjsi merged commit bacb2b5 into mars-project:master Feb 9, 2022
DataFrame automation moved this from Reviewer approved to Done Feb 9, 2022
v0.9 Release automation moved this from PR-In progress to PR-Done Feb 9, 2022
@qinxuye qinxuye deleted the bugfix/loc-iterative-tiling branch February 9, 2022 03:00
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Feb 9, 2022
Avoid iterative tiling for df.loc[:, fields] (mars-project#2685)
74cfbdd 
(cherry picked from commit bacb2b5)
@qinxuye qinxuye mentioned this pull request Feb 9, 2022
Merged
wjsi pushed a commit that referenced this pull request Feb 9, 2022
[BACKPORT] Avoid iterative tiling for df.loc[:, fields] (#2685) (#2689)
b33ae99
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjsi wjsi wjsi approved these changes

@hekaisheng hekaisheng hekaisheng approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: dataframe type: bug Something isn't working
Projects
DataFrame
  
Done
v0.9 Release
PR-Done
Milestone
v0.9.0b1
Development

Successfully merging this pull request may close these issues.

[BUG] df.loc[:, [fields]] triggered unnecessary iterative tiling
3 participants
@qinxuye @wjsi @hekaisheng