Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][TENSOR] Check chunks parameter for mt.random.rand and mt.random.randn #91

Closed
qinxuye opened this issue Jan 3, 2019 · 0 comments · Fixed by #100
Closed

[BUG][TENSOR] Check chunks parameter for mt.random.rand and mt.random.randn #91

qinxuye opened this issue Jan 3, 2019 · 0 comments · Fixed by #100
Labels
mod: tensor type: bug Something isn't working
Milestone
v0.2.0a1

Comments

@qinxuye
Copy link
Collaborator

qinxuye commented Jan 3, 2019

Describe the bug

chunks parameter has been renamed to chunk_size, but for mt.random.rand and mt.random.randn, we did not check the parameter. If chunks is specified, no exception raised.

Expected behavior

Raise ValueError if chunks is specified for mt.random.rand and mt.random.randn
@qinxuye qinxuye added type: bug Something isn't working mod: tensor to be backported Indicate that the PR need to be backported to stable branch labels Jan 3, 2019
@qinxuye qinxuye added this to the v0.2.0a1 milestone Jan 3, 2019
@qinxuye qinxuye removed the to be backported Indicate that the PR need to be backported to stable branch label Jan 3, 2019
@hekaisheng hekaisheng mentioned this issue Jan 4, 2019
Merged
fyrestone pushed a commit to fyrestone/mars that referenced this issue Feb 21, 2023
@hoarjour @UranusSeven
BUG: DataFrame.agg with built-in functions (mars-project#91)
f956381 
Co-authored-by: UranusSeven <109661872+UranusSeven@users.noreply.github.com>
fyrestone added a commit that referenced this issue Mar 14, 2023
@fyrestone @UranusSeven
@ChengjieLi28 @aresnow1 @qianduoduo0904 @hoarjour @wjsi
Merge code (#3330)
9b08d4a 
* Implements ColumnPruning optimization rule (#30)

Co-authored-by: ChengjieLi <chengjieli23@outlook.com>
Co-authored-by: aresnow <aresnow1@gmail.com>

* Fix execution hang on optimization error (#33)

* enh: Optimize groupby nunique implementation (#38)

* enh: Support passing mars objects when call df.map_chunk (#41)

* enh: Support `read_parquet` for GPU (#45)

* enh: Merge small data on shuffle mapper side (#49)

* Fix: `series.drop_duplicates()` failed (#53)

* Fix: dataframe.isna on scaler args (#55)

* enh: Support df or series type for apply function (#56)

* enh: Support running TPC-H queries on GPU (#60)

* Avoid creating too much thread pools (#62)

* enh: Optimize DataFrame.isin (#67)

* tst: Fix gpu CI (#42)

* enh: Refactor `read_buffers` & `write_buffers` for GPU (#68)

* Fix: ensure dataframe.all acts identical to pandas (#79)

* fix: Fix wrong results of `DataFrame.replace` (#86)

* enh: Add `skip_infer` paramter for all use defined functions (#76)

* fix: Modify signature of `df.map_chunk` (#87)

* BUG: DataFrame.agg with built-in functions (#91)

Co-authored-by: UranusSeven <109661872+UranusSeven@users.noreply.github.com>

* Fix dataframe.ewm  (#97)

* BUG: Fix dataframe.sample() (#99)

* BUG: df.apply with list input returns wrong answer when axis=1 (#100)

* BUG: Fix md.unique (#102)

* Fix implement ordered in md.cut (#104)

Co-authored-by: UranusSeven <109661872+UranusSeven@users.noreply.github.com>

* Fix: map_chunk output type inference (#111)

* Enh: support groupby plot (#113)

* ENH: Clear default context after execution (#115)

* BUG: fix supervisor start method (#116)

* BUG: Fix `date_range` and pin sphinx<6.0.0 (#118)

* BUG: handle missing merge key (#124)

* BUG: Fix `read_csv` with specific names and header (#130)

* BUG: needed cols being pruned (#134)

* BUG: Fix `read_parquet` with latest pyarrow (#135)

* BUG: Suppress `FutureWarning` (#108)

* Fix merge

* Add `_repr_mimebundle_`

... as `_repr_svg_` is deprecated in `Source` class of `graphviz`.

---------

Co-authored-by: UranusSeven <109661872+UranusSeven@users.noreply.github.com>
Co-authored-by: ChengjieLi <chengjieli23@outlook.com>
Co-authored-by: aresnow <aresnow1@gmail.com>
Co-authored-by: Chengjie Li <109656400+ChengjieLi28@users.noreply.github.com>
Co-authored-by: aresnow1 <109642806+aresnow1@users.noreply.github.com>
Co-authored-by: qianduoduo0904 <109654808+qianduoduo0904@users.noreply.github.com>
Co-authored-by: 黄浩杰 <65081722+hoarjour@users.noreply.github.com>
Co-authored-by: 刘宝 <po.lb@antgroup.com>
Co-authored-by: Wenjun Si <swj0066@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mod: tensor type: bug Something isn't working
Projects
None yet
Milestone
v0.2.0a1
Development

Successfully merging a pull request may close this issue.

Check parameters for rand and randn hekaisheng/mars
1 participant
@qinxuye