Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support missing argument for tensor.tosparse() and fill_value argument for sparse_tensor.todense() #1797

Merged
merged 1 commit into from Dec 17, 2020

Conversation

qinxuye
Copy link
Collaborator

@qinxuye qinxuye commented Dec 17, 2020

What do these changes do?

This PR support missing argument for tensor.tosparse() and fill_value argument for sparse_tensor.todense().

Related issue number

Resolves #1795 .

@qinxuye qinxuye added mod: tensor type: feature New feature to be backported Indicate that the PR need to be backported to stable branch labels Dec 17, 2020
@qinxuye qinxuye added this to the v0.7.0a2 milestone Dec 17, 2020
@qinxuye qinxuye added this to PR-In progress in v0.7 Release via automation Dec 17, 2020
@qinxuye qinxuye added this to In progress in Tensor via automation Dec 17, 2020
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tensor automation moved this from In progress to Reviewer approved Dec 17, 2020
@wjsi wjsi merged commit 641418d into mars-project:master Dec 17, 2020
Tensor automation moved this from Reviewer approved to Done Dec 17, 2020
v0.7 Release automation moved this from PR-In progress to PR-Done Dec 17, 2020
wjsi pushed a commit to wjsi/mars that referenced this pull request Dec 17, 2020
@qinxuye qinxuye deleted the feature/to-sparse-missing branch December 17, 2020 16:57
hekaisheng pushed a commit that referenced this pull request Dec 18, 2020
…ll_value` argument for `sparse_tensor.todense()` (#1797) (#1802)
@hekaisheng hekaisheng added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported already PR has been backported mod: tensor type: feature New feature
Projects
Tensor
  
Done
Development

Successfully merging this pull request may close these issues.

Support specifying missing value for tensor.tosparse()
3 participants