Add partial support for setitem with fancy indexing #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hekaisheng
added
mod: tensor
type: feature
hekaisheng
force-pushed
the
feature/setitem
branch
from
0eb7b8a
to
8c88c9e
Compare
hekaisheng
changed the title
hekaisheng
force-pushed
the
feature/setitem
branch
from
8c88c9e
to
d510f14
Compare
wjsi
force-pushed
the
feature/setitem
branch
from
eb4d6ac
to
909d884
Compare
hekaisheng
force-pushed
the
feature/setitem
branch
3 times, most recently
from
65320eb
to
4532829
Compare
hekaisheng
force-pushed
the
feature/setitem
branch
from
6822fd7
to
80ef5cd
Compare
added 2 commits
October 22, 2021 17:51
qinxuye
reviewed
Oct 23, 2021
wjsi
pushed a commit
to wjsi/mars
that referenced
this pull request
Oct 23, 2021
wjsi
pushed a commit
to wjsi/mars
that referenced
this pull request
Oct 23, 2021
wjsi
pushed a commit
to wjsi/mars
that referenced
this pull request
Oct 23, 2021
qinxuye
pushed a commit
that referenced
this pull request
Oct 23, 2021
qinxuye
added
backported already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR implements setitem with fancy indexes, as mentioned in title, it's not a complete implementation, works only when index on each axis is a tensor, mixed indexing is not supported now.