Add a document about how to implement a Mars operand #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hekaisheng
added
type: enhancement
hekaisheng
force-pushed
the
docs/operand-implementation
branch
from
6a46d0b
to
f05c190
Compare
|
Is it possible to call operand instead of operator to avoid ambiguity? |
qinxuye
changed the title
|
This PR explains how to implement an operand, from the developer perspective. What is your opinion, is that clear to you? @perfumescent |
added 3 commits
November 1, 2021 17:48
wjsi
pushed a commit
to wjsi/mars
that referenced
this pull request
Nov 2, 2021
hekaisheng
added a commit
to hekaisheng/mars
that referenced
this pull request
Nov 2, 2021
(cherry picked from commit 90ffab1)
wjsi
added
backported already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue number
Fixes #2269