Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sort_values for empty DataFrame or Series #2681

Merged
merged 5 commits into from
Feb 8, 2022
Merged

Fix sort_values for empty DataFrame or Series #2681

merged 5 commits into from
Feb 8, 2022

Conversation

hekaisheng
Copy link
Contributor

@hekaisheng hekaisheng commented Feb 7, 2022 •
edited
Loading

What do these changes do?

This PR fixes the failure for sort_values when input DataFrame/Series is empty.

Related issue number

Fixes #2649

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@hekaisheng hekaisheng added type: bug Something isn't working mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels Feb 7, 2022
@hekaisheng hekaisheng added this to the v0.9.0b1 milestone Feb 7, 2022
@hekaisheng hekaisheng added this to In progress in DataFrame via automation Feb 7, 2022
@hekaisheng hekaisheng added this to PR-In progress in v0.9 Release via automation Feb 7, 2022
qinxuye
qinxuye approved these changes Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wjsi
wjsi approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DataFrame automation moved this from In progress to Reviewer approved Feb 8, 2022
@wjsi wjsi merged commit 4fbf841 into mars-project:master Feb 8, 2022
DataFrame automation moved this from Reviewer approved to Done Feb 8, 2022
v0.9 Release automation moved this from PR-In progress to PR-Done Feb 8, 2022
@hekaisheng hekaisheng deleted the bugfix/sort-empty branch February 8, 2022 10:35
wjsi pushed a commit to wjsi/mars that referenced this pull request Feb 8, 2022
@hekaisheng @wjsi
Fix sort_values for empty DataFrame or Series (mars-project#2681)
4e7eb2c
hekaisheng added a commit to hekaisheng/mars that referenced this pull request Feb 8, 2022
@hekaisheng
Fix sort_values for empty DataFrame or Series (mars-project#2681)
8ba98a5 
(cherry picked from commit 4fbf841)
@wjsi wjsi mentioned this pull request Feb 8, 2022
Merged
@hekaisheng hekaisheng mentioned this pull request Feb 8, 2022
Closed
qinxuye pushed a commit that referenced this pull request Feb 8, 2022
@wjsi
[BACKPORT] Fix sort_values for empty DataFrame or Series (#2681) (#…
4b1d7b6 
…2686)
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@wjsi wjsi wjsi approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: dataframe type: bug Something isn't working
Projects
DataFrame
  
Done
v0.9 Release
PR-Done
Milestone
v0.9.0b1
Development

Successfully merging this pull request may close these issues.

[BUG] df.sort_values() failed when input dataframe is empty
3 participants
@hekaisheng @qinxuye @wjsi