Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix][ray] fix ray dataset compatibility #2693

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

chaokunyang
Copy link
Contributor

@chaokunyang chaokunyang commented Feb 10, 2022

What do these changes do?

Ray dataset in ray 1.10.0 has an incompatible change and it's not easy to fix unless we rewrite the dataset integration using datasource api of ray dataset. So we downgrade ray version to 1.9 and will relax version when we finished the rewrite.

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

qinxuye
qinxuye previously approved these changes Feb 10, 2022
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye added type: bug Something isn't working mod: ray integration to be backported Indicate that the PR need to be backported to stable branch labels Feb 10, 2022
@qinxuye qinxuye added this to In progress in Misc via automation Feb 10, 2022
@qinxuye qinxuye added this to PR-In progress in v0.9 Release via automation Feb 10, 2022
@qinxuye qinxuye added this to the v0.9.0b1 milestone Feb 10, 2022
@qinxuye
Copy link
Collaborator

qinxuye commented Feb 10, 2022

Misc automation moved this from In progress to Review in progress Feb 10, 2022
v0.9 Release automation moved this from PR-In progress to PR-Needs review Feb 10, 2022
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Misc automation moved this from Review in progress to Reviewer approved Feb 10, 2022
@wjsi wjsi merged commit dab1fa5 into mars-project:master Feb 10, 2022
Misc automation moved this from Reviewer approved to Done Feb 10, 2022
v0.9 Release automation moved this from PR-Needs review to PR-Done Feb 10, 2022
@wjsi wjsi removed the to be backported Indicate that the PR need to be backported to stable branch label Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod: ray integration type: bug Something isn't working
Projects
Misc
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants