Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix estimate_pandas_size for pd.MultiIndex #2707

Merged
merged 3 commits into from
Feb 11, 2022
Merged

Fix estimate_pandas_size for pd.MultiIndex #2707

merged 3 commits into from
Feb 11, 2022

Conversation

hekaisheng
Copy link
Contributor

@hekaisheng hekaisheng commented Feb 11, 2022 •
edited

What do these changes do?

This PR solves the error when estimating the size of pd.MultiIndex.

Related issue number

Fixes #2706

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@hekaisheng hekaisheng added type: bug Something isn't working mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels Feb 11, 2022
@hekaisheng hekaisheng added this to the v0.9.0b1 milestone Feb 11, 2022
@hekaisheng hekaisheng added this to In progress in DataFrame via automation Feb 11, 2022
@hekaisheng hekaisheng added this to PR-In progress in v0.9 Release via automation Feb 11, 2022
qinxuye
qinxuye approved these changes Feb 11, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wjsi
wjsi approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@wjsi wjsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DataFrame automation moved this from In progress to Reviewer approved Feb 11, 2022
@wjsi wjsi merged commit c3e8bdc into mars-project:master Feb 11, 2022
DataFrame automation moved this from Reviewer approved to Done Feb 11, 2022
v0.9 Release automation moved this from PR-In progress to PR-Done Feb 11, 2022
qinxuye pushed a commit to qinxuye/mars that referenced this pull request Feb 12, 2022
@hekaisheng
Fix estimate_pandas_size on pd.MultiIndex (mars-project#2707)
8bacbe1
@qinxuye qinxuye mentioned this pull request Feb 12, 2022
Merged
wjsi pushed a commit that referenced this pull request Feb 12, 2022
[BACKPORT] Fix estimate_pandas_size on pd.MultiIndex (#2707) (#2710)
e9d9ced
@qinxuye qinxuye deleted the bugfix/estimate-size branch February 17, 2022 14:15
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@wjsi wjsi wjsi approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported mod: dataframe type: bug Something isn't working
Projects
DataFrame
  
Done
v0.9 Release
PR-Done
Milestone
v0.9.0b1
Development

Successfully merging this pull request may close these issues.

[BUG] estimate_pandas_size results in a big error for MultiIndex
3 participants
@hekaisheng @qinxuye @wjsi