Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version mismatch between kubernetes and minikube #2986

Merged
merged 2 commits into from May 5, 2022
Merged

Fix version mismatch between kubernetes and minikube #2986

merged 2 commits into from May 5, 2022

Conversation

wjsi
Copy link
Member

@wjsi wjsi commented May 5, 2022

What do these changes do?

Fix version mismatch between kubernetes and minikube.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@wjsi wjsi added type: bug Something isn't working type: tests to be backported Indicate that the PR need to be backported to stable branch labels May 5, 2022
@wjsi wjsi added this to the v0.9.0rc3 milestone May 5, 2022
@wjsi wjsi requested a review from qinxuye as a code owner May 5, 2022 05:08
@wjsi wjsi added this to PR-In progress in v0.9 Release via automation May 5, 2022
@wjsi wjsi requested a review from hekaisheng as a code owner May 5, 2022 05:08
@wjsi wjsi added this to In progress in Misc via automation May 5, 2022
@wjsi wjsi removed the type: bug Something isn't working label May 5, 2022
qinxuye
qinxuye approved these changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hekaisheng
hekaisheng approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@hekaisheng hekaisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Misc automation moved this from In progress to Reviewer approved May 5, 2022
@hekaisheng hekaisheng merged commit 115ee0b into mars-project:master May 5, 2022
Misc automation moved this from Reviewer approved to Done May 5, 2022
v0.9 Release automation moved this from PR-In progress to PR-Done May 5, 2022
@wjsi wjsi deleted the test/fix_k8s branch May 5, 2022 07:52
wjsi added a commit to wjsi/mars that referenced this pull request May 5, 2022
@wjsi
Fix version mismatch between kubernetes and minikube (mars-project#2986)
7668cac
@wjsi wjsi mentioned this pull request May 5, 2022
Merged
wjsi added a commit to wjsi/mars that referenced this pull request May 5, 2022
@wjsi
Fix version mismatch between kubernetes and minikube (mars-project#2986)
b808862
qinxuye pushed a commit that referenced this pull request May 5, 2022
@wjsi
[BACKPORT] Fix version mismatch between kubernetes and minikube (#2986)…
c8188ba 
… (#2988)
@wjsi wjsi added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@hekaisheng hekaisheng hekaisheng approved these changes

Assignees
No one assigned
Labels
backported already PR has been backported type: tests
Projects
Misc
  
Done
v0.9 Release
PR-Done
Milestone
v0.9.0rc3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wjsi @qinxuye @hekaisheng