Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with NumPy v1.24 #3323

Merged
merged 3 commits into from
Jan 16, 2023

Conversation

vcfgv
Copy link
Contributor

@vcfgv vcfgv commented Jan 13, 2023

What do these changes do?

Related issue number

Fixes #3322
Fixes #3321

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@vcfgv vcfgv requested a review from a team as a code owner January 13, 2023 07:02
@vcfgv vcfgv changed the title Fix Fix compatibility with NumPy v1.24 Jan 13, 2023
@vcfgv vcfgv force-pushed the fix_numpy_1.24_compatibility branch from 4d0a7a5 to eb8aa9b Compare January 13, 2023 07:54
fyrestone
fyrestone previously approved these changes Jan 16, 2023
Copy link
Contributor

@fyrestone fyrestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fyrestone fyrestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhongchun zhongchun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fyrestone fyrestone merged commit 181fe51 into mars-project:master Jan 16, 2023
qianduoduo0904 pushed a commit to qianduoduo0904/mars that referenced this pull request Jan 16, 2023
* Fix

* More fixes

* Use latest scikit-learn

(cherry picked from commit 181fe51)
ChengjieLi28 pushed a commit to xorbitsai/mars that referenced this pull request Jan 17, 2023
* Fix

* More fixes

* Use latest scikit-learn

(cherry picked from commit 181fe51)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants