Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fetch executed tensor data from server #80

Merged
merged 14 commits into from
Dec 29, 2018

Conversation

hekaisheng
Copy link
Contributor

What do these changes do?

Add session.fetch method and check if tensor has been submitted in session.run. For LocalClusterSession and web.Session, they can fetch executed tensor from workers and submit other tensors to cluster. For LocalSession, fetch is not available, it will run all input tensors whether they have run or not.

Related issue number

fixes #17 from the client side, other related fixes may be done with #28

@qinxuye
Copy link
Collaborator

qinxuye commented Dec 28, 2018

Wonder why local session cannot fetch? LocalSession hold an executor which have all the executed data.

@hekaisheng
Copy link
Contributor Author

Wonder why local session cannot fetch? LocalSession hold an executor which have all the executed data.

okay...Executor hold data in _chunk_result, it can provide interface for fetch.

@qinxuye
Copy link
Collaborator

qinxuye commented Dec 28, 2018

Yeah, add an interface to Executor to supply fetch ability.

mars/web/session.py Outdated Show resolved Hide resolved
mars/deploy/local/session.py Show resolved Hide resolved
mars/session.py Outdated Show resolved Hide resolved
@qinxuye qinxuye added the type: feature New feature label Dec 29, 2018
mars/session.py Outdated Show resolved Hide resolved
mars/session.py Show resolved Hide resolved
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mars/session.py Outdated Show resolved Hide resolved
@qinxuye qinxuye merged commit a27cce5 into mars-project:master Dec 29, 2018
@hekaisheng hekaisheng deleted the fix_rerun_tensor branch December 29, 2018 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod: client type: bug Something isn't working type: feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][DISTRIBUTED] client will hang if submit the same graph again
3 participants