Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read_csv execution on GPU #859

Merged
merged 3 commits into from
Dec 12, 2019
Merged

Conversation

hekaisheng
Copy link
Contributor

What do these changes do?

We passed specific dtypes when call cudf.read_csv, as object type is unsupported in cuDF, we treat it as string type as default.

Related issue number

Fixes #852

@hekaisheng hekaisheng added type: bug Something isn't working mod: dataframe to be backported Indicate that the PR need to be backported to stable branch labels Dec 12, 2019
@hekaisheng hekaisheng added this to the v0.3.0rc1 milestone Dec 12, 2019
@hekaisheng hekaisheng added this to In progress in DataFrame via automation Dec 12, 2019
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issue could be fixed.

mars/dataframe/datasource/read_csv.py Show resolved Hide resolved
DataFrame automation moved this from In progress to Reviewer approved Dec 12, 2019
Copy link
Collaborator

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit d853f9c into mars-project:master Dec 12, 2019
DataFrame automation moved this from Reviewer approved to Done Dec 12, 2019
hekaisheng added a commit to hekaisheng/mars that referenced this pull request Dec 14, 2019
qinxuye pushed a commit that referenced this pull request Dec 14, 2019
@qinxuye qinxuye added backported already PR has been backported and removed to be backported Indicate that the PR need to be backported to stable branch labels Dec 14, 2019
@hekaisheng hekaisheng deleted the bugfix/gpu branch January 14, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported already PR has been backported hw: nvidia gpu mod: dataframe type: bug Something isn't working
Projects
DataFrame
  
Done
Development

Successfully merging this pull request may close these issues.

[BUG] Read csv failed on GPU
3 participants