Accelerate LU when input has one chunk
#905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinxuye
changed the title
LU tile when input has one chunkLU when input has one chunk
qinxuye
added
the
to be backported
qinxuye
force-pushed
the
enh/lu-tile-one-chunk
branch
from
fca4041
to
75ffa0a
Compare
wjsi
pushed a commit
to wjsi/mars
that referenced
this pull request
Jan 9, 2020
wjsi
pushed a commit
to wjsi/mars
that referenced
this pull request
Jan 9, 2020
wjsi
added
backported already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As described in #904 , when input has one chunk, execution of
LUis super slow. This PR accelerated the process.Because
LUis used in randomized_svd, and the latter one is widely used inPCAandTruncatedSVD, I test the unittests intest_pca, the running time reduced from 5min 14s to 1min 35s on my laptop. I think this PR can accelerate the CI as well.Related issue number
Fixes #904 .