Skip to content
This repository has been archived by the owner on Jun 11, 2022. It is now read-only.

Not specific to create react app #2

Closed
InsidersByte opened this issue Aug 15, 2016 · 2 comments
Closed

Not specific to create react app #2

InsidersByte opened this issue Aug 15, 2016 · 2 comments

Comments

@InsidersByte
Copy link

Thanks for the awesome buildpack!

I know this is stated as the create react app buildpack, but it is useful for other react apps.

I am currently using it on my own react app and the requirements are that it needs to be static and that it has build command which runs webpack (or browserify I guess).

@mars
Copy link
Owner

mars commented Aug 15, 2016

Great to hear that it's working for your non-create-react-app app.

It's true today, all this buildpack relies on is:

  • npm run build performs the transpile/bundling
  • the file build/index.html exists at runtime

It's possible these specs will change as create-react-app evolves, but its utility as a general purpose SPA deployer is a welcome perspective 🤔

Thanks for the kind issue 🌟😄

@InsidersByte
Copy link
Author

InsidersByte commented Aug 16, 2016

I was thinking the same about a general purpose SPA deployer! If more functionality is added to create-react-app then functionality could be added to it.

The index.html just has to exist at the root set in static.json.

@mars mars closed this as completed in 4c7b922 Aug 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants