Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update next to the latest version 馃殌 #27

Closed
wants to merge 1 commit into from

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Feb 5, 2018

Version 5.0.0 of next was just published.

Dependency next
Current Version 4.2.3
Type dependency

The version 5.0.0 is not covered by your current version range.

If you don鈥檛 accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of next.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don鈥檛 have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Commits

The new version differs by 173 commits.

  • 4697cbc Release 5.0.0
  • c5ddfea Merge branch 'canary'
  • 8308a33 Revert "Require files directly instead of resolving them (#3683)" (#3684)
  • fa03f0b Require files directly instead of resolving them (#3683)
  • ed12293 Add tests for universal webpack (#3680)
  • 70295f2 Make links text
  • cdbbe92 Add update notifier (#3678)
  • 9498fc6 Use correct port in with-zones example (#3679)
  • 31b8e7e Indicate how to import fonts (#3676)
  • 863d4d3 Make sure externals logic works on Windows. (#3677)
  • b8f189f do not use window.history if inside iframe (#3437)
  • 3bbfbfa Refactor redux observable example (#3495)
  • 4d9cf19 [with-apollo] Use getDataFromTree in browser (#3457)
  • 97cf428 [Example] with-polyfills : show how to load polyfills (#3568)
  • 0da17ca Upgrade source-map-support

There are 173 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don鈥檛 help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 馃尨

@mars
Copy link
Owner

mars commented Feb 6, 2018

This is currently blocked by a runtime error:

{ Error: Cannot find module '/tmp/build_9552567dc17b73c2284c82ccd1aa9d10/mars-heroku-nextjs-1fb77a7/node_modules/next/dist/pages/_document.js'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.8 (/app/.next/dist/bundles/pages/_document.js:86:18)
    at __webpack_require__ (/app/.next/dist/bundles/pages/_document.js:23:31)
    at Object.7 (/app/.next/dist/bundles/pages/_document.js:78:18)
    at __webpack_require__ (/app/.next/dist/bundles/pages/_document.js:23:31)
    at /app/.next/dist/bundles/pages/_document.js:70:18
    at Object.<anonymous> (/app/.next/dist/bundles/pages/_document.js:73:10) code: 'MODULE_NOT_FOUND' }

Looks like paths are getting hardcoded into the bundle at buildtime 馃槱

@mars
Copy link
Owner

mars commented Feb 6, 2018

New facts reveal that the fix for this is already merged to Next master, to be in upcoming release.

@mars mars mentioned this pull request Feb 8, 2018
@mars
Copy link
Owner

mars commented Feb 8, 2018

New PR #29 opened to verify the eventual fix

@mars mars closed this Feb 8, 2018
@greenkeeper greenkeeper bot deleted the greenkeeper/next-5.0.0 branch March 26, 2018 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant