Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check both start and end for coords #6

Merged

Conversation

AndreaGuarracino
Copy link
Contributor

This fix avoids

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/graph.rs:362:49
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

and helped me in debugging pangenome/pggb#299.

@danydoerr
Copy link
Member

Thanks for 1) finding the bug 2) suggesting a fix! I have a bad feeling that there's more to it than this, because if a path segment has an end, it must have a start. Can you provide me with the graph?

@danydoerr
Copy link
Member

@AndreaGuarracino Actually, I just need to know one path ID to see what went wrong in parsing it :)

@AndreaGuarracino
Copy link
Contributor Author

Enjoy!

gunzip smoothxg_block_0.gfa.gz

anacus table -a -c edge smoothxg_block_0.gfa | grep -e '\s0$'
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/graph.rs:362:49
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

smoothxg_block_0.gfa.gz

@danydoerr
Copy link
Member

Awesome, thanks!

@danydoerr
Copy link
Member

@AndreaGuarracino Question: How do I have to interpret these coordinates: HG02572#1#JAHAOW010000052.1:1087990-1165222_77032?

@AndreaGuarracino
Copy link
Contributor Author

HG02572#1#JAHAOW010000052.1:1087990-1165222 is the original name of the path in the graph in input for smoothxg (here I am smoothing a subgraph for debugging, so you have a coordinate range in the name, that is 1087990-116522). The second value, 77032, indicates where the starting coordinate of a range in HG02572#1#JAHAOW010000052.1:1087990-1165222 (smoothxg applies POA on graph blocks, that corresponds to pieces of paths). So, in general, it is ORIGINALPATHNAME_START.

@danydoerr danydoerr merged commit e01ae82 into marschall-lab:main Jun 17, 2023
danydoerr pushed a commit that referenced this pull request Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants