-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export the encoding tables #41
Comments
Hmm... those are pretty tightly coupled to the current implementation, and we might well want to change those radically as the algorithms change (e.g. maybe a constant time implementation that doesn't need tables at all? Or perhaps a different structure that is more amenable to SIMD?). I think perhaps it would be a better route to simply take the |
Closing due to inactivity. |
Even if the implementation changes it would be nice to have the encode tables around and exported. Rationale:
This now means that I have to the encoding tables in 2 places, once from base64 and once in my own code. Would be cleaner when the is only one place to get the tables from (even if the encoder gets implemented differently, access to the underlying alphabet should be available). Maybe instead tables as raw just expose an API that gives an iterator back. Maybe consider reopening this ticket and export the tables in future versions, thanks. |
Thanks for the use case description, that helps. This should be doable as part of #157. |
I'd like to reuse the encoding tables for specialised uses, like fixed-length encodings.
It would be great if
tables::XX_ENCODE
were public.The text was updated successfully, but these errors were encountered: