Extract operation resolvers and execute them after path helpers #152
Conversation
Result of path helper of web framework extension will be resolved by marshmallow extension regardless of the order of extensions.
|
@yoichi What about this PR is backwards-incompatible? Isn't this just exposing a new hook, or am I missing something? |
|
I thought extracting a part of functionality of path_helper introduce some incompatibility. But that was my misunderstanding. |
| @@ -12,6 +12,7 @@ There are three types of helper functions: | |||
|
|
|||
There was a problem hiding this comment.
Above line will need to be changed to "four".
|
@yoichi OK, thanks for the clarification. If this doesn't introduce backwards incompatibilities, then I think we should go ahead and merge this. |
docs/writing_plugins.rst
Outdated
|
|
||
| * Definition helpers | ||
| * Path helpers | ||
| * Operation resolvers |
There was a problem hiding this comment.
@yoichi Would it make sense to call these "Operation helpers" for consistency?
There was a problem hiding this comment.
Yes. They don't have to resolve something and call them helpers like existing ones seems better. I'll push a change.
Thanks for the suggestion
|
Looks good to me. Thanks! |
Solve #136
NOTE: This fix introduce incompatible change to extension mechanism.
Thanks,