Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to access APISpec components in plugin init_spec #539

Merged
merged 3 commits into from Feb 14, 2020
Merged

Allow to access APISpec components in plugin init_spec #539

merged 3 commits into from Feb 14, 2020

Conversation

Colin-b
Copy link
Contributor

@Colin-b Colin-b commented Feb 12, 2020

closes #538

Note that I tried to manually follow flake8 as my corporate network is using a self signed certificate to perform "man in the middle" preventing Git to access flake8 repo on gitlab (so pre-commit was failing).

Copy link
Member

@lafrech lafrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIU, flake8 is fine. The CI issues are with black.

I don't understand your setup but I suppose you can pip install flake8 black and run them. Or just apply manually the changes in there: https://dev.azure.com/sloria/sloria/_build/results?buildId=2793&view=logs&j=7e27d0d1-c3b5-5589-c3a3-eb2d9b518da8&t=f9c3c3ee-9bfd-5d70-3f98-d6c193ea86e4.

Or wait until I get the time to do it myself.

Otherwise, this is fine. Just a nitpick in the test.

tests/test_core.py Outdated Show resolved Hide resolved
Use helper to retrieve schemas
@Colin-b
Copy link
Contributor Author

Colin-b commented Feb 12, 2020

AFAIU, flake8 is fine. The CI issues are with black.

I don't understand your setup but I suppose you can pip install flake8 black and run them. Or just apply manually the changes in there: https://dev.azure.com/sloria/sloria/_build/results?buildId=2793&view=logs&j=7e27d0d1-c3b5-5589-c3a3-eb2d9b518da8&t=f9c3c3ee-9bfd-5d70-3f98-d6c193ea86e4.

Or wait until I get the time to do it myself.

Otherwise, this is fine. Just a nitpick in the test.

I manually applied flake8 before but I was unsure something else was performed by pre-commit lib.
I applied black as well and it refactored the test :)

@Colin-b Colin-b requested a review from lafrech February 12, 2020 17:36
@lafrech lafrech merged commit 0969b06 into marshmallow-code:dev Feb 14, 2020
@Colin-b Colin-b deleted the feature/components_in_init_spec branch February 15, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to access APISpec.components in plugin init_spec method
2 participants