Catch warnings in tests & remove support for older URLFor argument syntax #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies the error filter to force test failures on warnings, and does the necessary cleanup. Primarily, that means identifying the two classes of `ignore:` rules which are necessary to handle cases outside of this library's control. Secondarily, it forces the deprecation of the older url_for field specification syntax, which cannot be supported cleanly. Since this was deprecated in the last release, it is presumably safe to remove it, but the change is still noted as breaking in the changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've rebased this off of #243 to pick up the latest changes and resolve conflicts and added an additional changeset. My added change sets
filterwarnings = errorand deals with the consequences of that setting.Apply filterwarnings = error to tests and update
This applies the error filter to force test failures on warnings, and does the necessary cleanup. Primarily, that means identifying the two classes of
ignore:rules which are necessary to handle cases outside of this library's control. Secondarily, it forces the deprecation of the older url_for field specification syntax, which cannot be supported cleanly. Since this was deprecated in the last release, it is presumably safe to remove it, but the change is still noted as breaking in the changelog.