-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
field_for() converter for Relationships not detecting nullable=False #336
Comments
Hi @AbdealiJK , Tried to replicate the issue based on the debug notes, @_add_relationship_kwargs checks for a uselist attribute, if it not set to Code used to test:
|
In the example I was speaking of - The sqlalchemy supports it - so I would expect marshmallow-sqlalchemy to also give me the same behavior |
Hi @AbdealiJK , Made an attempt to address the issue and have raised PR for same, using the DIRECTORY_MAPPING attribute available to decide if a column should be nullable or not, |
Hi, I had a case where I had the following (this is example code):
And when I tried to do an
author = auto_field()
here on 'author' relationship - it gave me an error.i dug into it, and I found the following:
This got me confused ... cause it looks like :
required=True
correctlyrequired=True
correctlyThe text was updated successfully, but these errors were encountered: