Resolution for Issue #1, added SQLAlchemy ORM dialect types for MySQL #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… types for MySQL
|
Thanks @rmackinnon . The Travis build is failing due to flake8 errors. Please uses 4 spaces rather than tabs for indentation. Would you mind making that change? |
|
This is what I get for using nano for a quick edit instead of PyCharm like I do for everything else.... sigh Pulled into to PyCharm, and sure enough the columns were no where correct. Re-aligned per PEP8. |
| mysql.LONGBLOB: fields.String, | ||
|
|
||
| mysql.SET: fields.List, | ||
| mysql.ENUM: fields.Enum |
There was a problem hiding this comment.
The Enum field is now deprecated in favor of using the validate.OneOf validator. I will change this to fields.Field when I merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that convert.py was missing the correct stitching for SQLAlchemy ORM dialect for MySQL column types. Added as pull request per @sloria.
Cheers!