New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added money type to SQLA_TYPE_MAPPING #218
Conversation
Why py27-lowest don't have MONEY? It's correct? |
It's probably not a py2-specific issue. Looks like our lowest supported SQLAlchemy version (0.9.7) doesn't support |
May be better to add a check and add this field only if the sqla version is > some value rather than bumping it up |
I'm fine with either. Looks like it was added in 1.2, which is ~1.5 years old at this point. |
So what are we doing? We update the version or we write factory? |
Well, we're already doing if hasattr(sa, "JSON"):
SQLA_TYPE_MAPPING[sa.JSON] = fields.Raw so we could do something similar if hasattr(postgres, "MONEY"):
SQLA_TYPE_MAPPING[postgres.MONEY] = fields.Decimal |
Done |
When it will be merged? |
Will probably release this over the weekend. |
Thanks! |
This is released in 0.17.0 |
No description provided.