Require fields for non-nullable properties. #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is helpful for the common use case of creating a new record from data: if required fields are missing, we should throw an error. For partial updates, users would pass `partial=True` to the `ModelSchema` constructor as usual.
Also temporarily install marshmallow from dev--didn't realize partial was such a new addition.
jmcarp
force-pushed
the
require-not-nullable
branch
from
e1ee46f
to
98984e8
Compare
|
I'm going to cut the marshmallow 2.2.0 release before merging this, so we don't have to change .travis.yml |
|
Though, I suppose the minimum supported marshmallow version would need to be bumped up to 2.2.0 |
|
Actually, this doesn't technically break backwards compat with marshmallow 2.0.0 ( |
|
Btw, marshmallow 2.2.0 is released, so you should be able to do marshmallow_version_info = tuple(map(int, marshmallow.__version__.split('.')))
if marshmallow_version_info >= (2, 2, 0):
#... |
Avoid the need to pass `partial` and inspect version number in the tests: the tests are responsible for checking deserialization behavior, not required fields or partial loading.
|
IMO it's simpler just to deserialize complete objects in the tests, so we don't have to worry about |
sloria
added a commit
that referenced
this pull request
Oct 27, 2015
Require fields for non-nullable properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful for the common use case of creating a new record from
data: if required fields are missing, we should throw an error. For
partial updates, users would pass
partial=Trueto theModelSchemaconstructor as usual.