Use Session.get() in get_instance instead of Session.query()
#548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Session.get() tries to fetch an object from the session's identity map if it exists, and performs a SQL query otherwise. This can help improve load performance by reducing number of SQL queries, especially for nested relationships, if everything is already available into the session.
|
TIL about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session.get() (SQLA docs) tries to fetch an object from the session's identity map if it exists, and performs a SQL query otherwise.
This improves
load()performance by reducing number of SQL queries, especially for nested relationships, if everything is already available into the session.