feat(TextDateInput): Add new precise date input component #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matdiak
reviewed
Jun 24, 2024
src/TextDateInput/TextDateInput.tsx
Outdated
| import { Box } from '../Box' | ||
| import { Fieldset, FieldsetProps } from '../fields/Fieldset' | ||
|
|
||
| export type FullDateFormat = { |
There was a problem hiding this comment.
I actually renamed in in sign-up. We could match is so that it is DateObjectType
matdiak
reviewed
Jun 24, 2024
src/TextDateInput/TextDateInput.tsx
Outdated
| | 'day' | ||
| | 'month' | ||
| | 'year' | ||
| | 'all' |
There was a problem hiding this comment.
I think there will be more errors types encopassed under all. Maybe a better approach would be to pass an array as a prop for example, fieldsWithError: ['day', 'month'] and we will evaluate it whereever we use it?
matdiak
reviewed
Jun 24, 2024
| } | ||
|
|
||
| const Template: FC = (props: TextDateInputProps) => { | ||
| const [_value, setValue] = useState<FullDateFormat>({ |
There was a problem hiding this comment.
This was left over from a previous approach where there was already a value defined, we can use value now though so I'll update this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot / video
What does this do?
Adds a new
TextDateInputcomponent that allows for a precise date to be entered in specificday,monthandyearinput fields