Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vis.1: list equivalent key bindings on the same line #1097

Closed
wants to merge 1 commit into from
Closed

vis.1: list equivalent key bindings on the same line #1097

wants to merge 1 commit into from

Conversation

rnpnr
Copy link
Collaborator

@rnpnr rnpnr commented May 3, 2023 •
edited
Loading

it is hard to tell which line <C-u> and <C-d> are supposed to belong to in the current version.

Note that if keeping the pairs on separate lines is preferred I can update the patch to say same as xxx instead.

see #1033

@rnpnr
vis.1: list equivalent key bindings on the same line
f8a38b9 
it is hard to tell which line <C-u> and <C-d> are supposed to belong to
in the current version.

see martanne#1033
@mcepl
Copy link
Contributor

mcepl commented May 3, 2023 •
edited
Loading

I really don’t which version is better.

Old version:

screenshot-2023-05-03_17-05-1683129313

New version:

screenshot-2023-05-03_17-05-1683129337

Both of them look strange.

@rnpnr
Copy link
Collaborator Author

rnpnr commented May 3, 2023

Here are two alternatives:
image
or
image
Are either of them better?

@mcepl
Copy link
Contributor

mcepl commented May 3, 2023

Are either of them better?

I really don't like the second one. So I think it is between this PR and the current state.

@tosch42
Copy link
Contributor

tosch42 commented May 5, 2023 •
edited
Loading

The current state is very confusing. I'd expect C-p and C-u to do the same thing, since one is reading from top to bottom. I prefer the new version because it supports the natural reading flow.

mcepl
mcepl approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@mcepl mcepl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged into https://git.sr.ht/~mcepl/vis/tree.

@ninewise
Copy link
Collaborator

Applied in e6fc48d

@ninewise ninewise closed this May 23, 2023
@rnpnr rnpnr deleted the manpage-keybind-table branch May 24, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcepl mcepl mcepl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rnpnr @mcepl @tosch42 @ninewise