New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print keybindings starting with space correctly #1111
Print keybindings starting with space correctly #1111
Conversation
Hi Max, thanks for the patch! This fixes one of the issues listed in #1060 but doesn't replace any additional spaces with |
Hi Randy, sure. I didn't think about this. I have updated this pull request. I hope it's not too complicated. The main difficulty is that spaces (1 byte each) get replaced with |
Definitely a little more complicated then I was expecting but its |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the minor comment above this looks good to me. If you want to
squash the commits I would be OK with merging.
I will just wait a couple days to see if anyone else has any comments.
2b8c7e1
to
6ce9675
Compare
Fixes martanne#1060 - :help doesn't display mappings starting with <Space> correctly Co-authored-by: Randy Palamar <palamar@ualberta.ca>
6ce9675
to
6be370d
Compare
Applied! Thanks for your work getting this patch in shape! |
I get the following warning when building the latest version with this change:
|
Oh, looks like I missed this. I'll change the type of |
Fixed in 599ced0. Sorry about that I don't know how I missed it. |
Bug fix for #1060.