Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csproj and psm1 extensions to filetype #1131

Closed
wants to merge 1 commit into from
Closed

Add csproj and psm1 extensions to filetype #1131

wants to merge 1 commit into from

Conversation

milhnl
Copy link
Contributor

@milhnl milhnl commented Sep 18, 2023

Hey all, just a small change, so not much to comment.

Copy link
Collaborator

@rnpnr rnpnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll say yes to the .psm1 type but no to the .csproj type. The
latter seems to be auto-generated and mostly used by vscode. I don't
really think supporting every random auto-generated file from other text
editors makes any sense for vis.

You can easily add support for it locally in visrc.lua, just put this
somewhere after require('vis'):

table.insert(vis.ftdetect.filetypes.xml.ext, "%.csproj$")

@milhnl
Copy link
Contributor Author

milhnl commented Sep 18, 2023

I'm ok with not adding it, but I (and others working with dotnet projects) do need to edit it by hand (and not just small edits, it's just initially autogenerated), so if that makes you reconsider, great. It's also not vscode specific at all. The modification for my visrc you propose is already in there, but yours is more efficient. Thanks :)

@mcepl
Copy link
Contributor

mcepl commented Sep 20, 2023 via email

@milhnl
Copy link
Contributor Author

milhnl commented Sep 20, 2023

Sure. But the reasoning is still incorrect.

@rnpnr
Copy link
Collaborator

rnpnr commented Sep 20, 2023

I just pushed 7367ea8 which should also cover your csproj file.

Thanks for the patch!

@rnpnr rnpnr closed this Sep 20, 2023
@milhnl
Copy link
Contributor Author

milhnl commented Sep 20, 2023

Smart. Thanks. file says it's text/plain on my system but that's not vis' problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants