-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lua: refactor complete-filename plugin #1148
Conversation
I have now rebased that patch by João on the top of this PR as https://git.sr.ht/~mcepl/vis/commit/09e25541cace . I think it is sufficiently obvious and simple thing, which can only help. If not here, then I will probably send it to the list, when you merge this PR. |
a56e623
to
57e9da9
Compare
I made a couple changes to remove some differences between the two modes:
For the second point |
Thinking about it again this doesn't belong in |
Looking at the code: local cmdfmt = "vis-complete --file '%s'"
if expand then cmdfmt = "vis-open -- '%s'*" end Shouldn’t be fixed in both? |
Sorry I mean in the shell scripts themselves. |
Actually, can you reproduce it? Even without João’s commit, |
Yes, when invoked inside vis via I think I will just apply this since it cleans up the docs and simplifies a few things and leave it up to someone else to propose a change for expanding |
There are probably more things to simplify but at least this makes it easier to see what exactly is different between `<C-x><C-f>` and `<C-x><C-o>`. Some differences were removed: * whitespace in range is treated the same for both actions * empty range will expand to files in CWD for both actions closes martanne#1146: Complete file name and file path swapped in doc
And why should it matter when I have shown that |
It doesn't if invoked inside vis. Open a new file and do |
There are probably more things to simplify but at least this makes it easier to see what exactly is different between
<C-x><C-f>
and<C-x><C-o>
.closes #1146
Comments on how to simplify this more would be appreciated!