Implement raw subqueries #230
Conversation
treagod
force-pushed
the
raw-filter
branch
3 times, most recently
from
9892022
to
b8e9b14
Compare
|
@ellmetha I'll left two comments regarding the connecting object (which is related to the formatting issue), which is why I didn't touch any of the connection findings |
| it "raises an error when filtering with a misspelled column in a raw SQL condition", tags: "raw" do | ||
| Tag.create!(name: "crystal", is_active: true) | ||
|
|
||
| expect_raises(Exception) do |
There was a problem hiding this comment.
Should we target a more specific exception class here?
There was a problem hiding this comment.
We could, but I'm not sure it's useful here. All database types throw their own exception. I didn't see a common ancestor of these database exceptions, so I chose this generic exception type instead of checking each individual database exception.
What do you think?
There was a problem hiding this comment.
We could define specific blocks for every supported backend and verify that the most precise exception is raised (by wrapping #expect_raises calls within #for_mysql / #for_postgresql / #for_sqlite blocks). That way, other types of exceptions wouldn't be "caught" if there is an issue with the underlying code, but that's very unlikely anyway. Let's keep it that way!
|
Thanks for the work on this @treagod! We are getting closer! I left additional comments and small fix suggestions; we should be able to merge this very soon. 🎉 |
This commit adds support for raw SQL queries to the
#filtermethod and q expressions.#44