add odd? and even? to the loop tag
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellmetha
reviewed
May 23, 2024
src/marten/template/tag/for/loop.cr
Outdated
Comment on lines
40
to
46
| def odd? | ||
| !even? | ||
| end | ||
|
|
||
| def even? | ||
| @index % 2 == 0 | ||
| end |
There was a problem hiding this comment.
Why not use the existing #odd? and #even? methods?
Suggested change
| def odd? | |
| !even? | |
| end | |
| def even? | |
| @index % 2 == 0 | |
| end | |
| def odd? | |
| @index.odd? | |
| end | |
| def even? | |
| @index.even? | |
| end |
There was a problem hiding this comment.
Whoa!! I haven't thought about it. Thanks @ellmetha. I'll make the change.
Comment on lines
+111
to
+112
| loop.index = 2 | ||
| loop.odd?.should eq false |
There was a problem hiding this comment.
I would expect this to be in another spec example (eg. returns false if the index is not odd).
Comment on lines
+125
to
+126
| loop.index = 1 | ||
| loop.even?.should eq false |
There was a problem hiding this comment.
Same remark here: this could be in its own spec example (returns false if the index is not even).
ellmetha
approved these changes
May 24, 2024
|
Thanks for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used modulo 2 to check for "even-ness". Zero is considered as even.
#201