Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent properties in autonomous regions file #18

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

martgnz
Copy link
Owner

@martgnz martgnz commented Feb 6, 2024

I think this was an oversight when we wrote the properties script. This ensures that we have same properties (name, id) in all the files.

Right now it's including the original metadata and we don't need all of it.

before

imagen

after

imagen

@martgnz martgnz changed the title Consistent properties Consistent properties in autonomous regions file Feb 6, 2024
@LuisSevillano
Copy link
Collaborator

Indeed this should be the case, go ahead!

Copy link
Collaborator

@LuisSevillano LuisSevillano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid 👍

@martgnz martgnz merged commit 6ef466a into master Feb 10, 2024
@martgnz martgnz deleted the consistent-properties branch February 10, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants