Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG/ISSUE] Tooltip text misleading on "Manage ignored updates" #1008

Closed
5 tasks done
eidylon opened this issue May 5, 2023 · 0 comments · Fixed by #1021
Closed
5 tasks done

[BUG/ISSUE] Tooltip text misleading on "Manage ignored updates" #1008

eidylon opened this issue May 5, 2023 · 0 comments · Fixed by #1021
Assignees
Labels
appearance bug Something isn't working ready-to-go

Comments

@eidylon
Copy link

eidylon commented May 5, 2023

Before submitting the issue

  • I have checked that the bug is not a duplicate or, if it is, it needs to be reopened
  • I have checked that I am running the latest version of WingetUI
  • I have tried resetting and reinstalling WingetUI and the issue persisted or happened again
  • I have checked the FAQ section for solutions
  • I have read the contributing guidelines and I agree with the Code of Conduct

Describe the bug

The tooltip on the Manage ignored updates button says Reset blacklist.
This is misleading, and makes you think clicking on the button will clear all items you've blacklisted.

It should instead say something like Manage programs excluded from updates, indicating it will take you to a manage screen as opposed to just blanket clearing the list.

To Reproduce

Steps to reproduce the behaviour:

  1. Mouse over the Manage ignored updates button

Expected behaviour

The tooltip should be more accurate to what the button will do.

Screenshots

image

The Log

🟡 Using bundled lang file (forced=False)
🟡 Using bundled lang file (forced=True)
It took 0.01600027084350586 to load all language files
🟢 checkQueue Thread started!
🔵 Starting main application...
Scanning for instances...
Found lock file(s), reactivating...
 * Serving Flask app 'WingetUI backend'
 * Debug mode: off
🔵 Starting update check
🔵 Version URL: https://versions.marticliment.com/versions/wingetui.ver
🟢 Updates not found
🟢 Downloaded latest metadata to local file
🔵 Loaded metadata from local file
b'v1.4.10173\r\n'
None
updating winget
Reactivation signal ignored: RaiseWindow_[1683246817.5760682]
{'wingetFound': True, 'scoopFound': False, 'chocoFound': False, 'sudoFound': True, 'wingetVersion': 'v1.4.10173\r', 'scoopVersion': 'Scoop is disabled', 'chocoVersion': 'Chocolatey is disabled', 'sudoVersion': 'gsudo v2.0.4 (Branch.tags-v2.0.4.Sha.506efa024af0cef6e4b0cfec42e0c8c5d0b1472c)\r'}
🔵 Reached main ui load milestone
🔵 Is Dark
Can't disconnect
🔵 Starting winget search
🟢 Discover tab loaded
🟢 Found valid cache for winget!
Can't disconnect
Can't disconnect
🔵 Starting winget file update...
🟢 Starting winget search, winget on C:\Users\aabdi\AppData\Local\Programs\WingetUI\winget-cli\winget.exe...
🟢 Upgrades tab loaded
Can't disconnect
🟢 Starting winget search, winget on C:\Users\aabdi\AppData\Local\Programs\WingetUI\winget-cli\winget.exe...
🟢 Discover tab loaded
Can't disconnect
🟢 Settings tab loaded!
🟢 About tab loaded!
🟢 Main application loaded...
🟢 Total packages: 4482
🟢 Winget search finished
🟠 Package Piriform.CCleaner.ProTrial is legacy blacklisted
🟠 Package Ultimaker.Cura is legacy blacklisted
🟢 Searching for string ""
🟢 Searching for string ""
🟢 Total packages: 0
🟡 package Entity Framework 6.1.3 Tools  for Visual… failed parsing, going for method 2...
Entity Framework 6.1.3 Tools  for Visual… {2A56910C-69C8-495D-8ED8-9080F0A14E58}     14.0.41103.0 85
🟡 package Update for  (KB2504637) failed parsing, going for method 2...
Update for  (KB2504637)                   {CFEF48A8-BFB8-3EAC-8BA5-DE4F8AA267CE}.KB… 1 85
🟢 Winget uninstallable packages search finished
🟢 Searching for string ""
🟢 Searching for string ""
🟢 Total packages: 337
🟢 Winget cache rebuilt
🟢 Total packages: 4482
Win32Mica Error: win32 version 19045 is not supported
🟢 Starting winget search, winget on C:\Users\aabdi\AppData\Local\Programs\WingetUI\winget-cli\winget.exe...
🟢 Searching for string "F"
🟢 Searching for string "Fi"
🟢 Searching for string "Fil"
🟢 Searching for string "File"
🟢 Searching for string "Files"
🟡 package Entity Framework 6.1.3 Tools  for Visual… failed parsing, going for method 2...
Entity Framework 6.1.3 Tools  for Visual… {2A56910C-69C8-495D-8ED8-9080F0A14E58}     14.0.41103.0 85
🟡 package Update for  (KB2504637) failed parsing, going for method 2...
Update for  (KB2504637)                   {CFEF48A8-BFB8-3EAC-8BA5-DE4F8AA267CE}.KB… 1 85
🟢 Winget uninstallable packages search finished
🟢 Searching for string ""
🟢 Searching for string ""
🟢 Total packages: 337
🟢 Searching for string "File"
🟢 Searching for string "Fil"
🟢 Searching for string "Fi"
🟢 Searching for string "F"
🟢 Searching for string ""
🟢 Searching for string ""
Reloading sources...
Updated scoop packages with result 1
Updated Winget packages with result 0
b''
b"Chocolatey v1.2.1\r\nDirectory 'C:\\Users\\aabdi\\AppData\\Local\\Programs\\WingetUI\\choco-cli\\lib' does not exist.\r\nUnknown command update. Setting to list.\r\nchocolatey - https://community.chocolatey.org/api/v2/ | Priority 0|Bypass Proxy - False|Self-Service - False|Admin Only - False.\r\n"
🟢 Starting winget search, winget on C:\Users\aabdi\AppData\Local\Programs\WingetUI\winget-cli\winget.exe...
🟢 Winget search finished
🟠 Package Piriform.CCleaner.ProTrial is legacy blacklisted
🟠 Package Ultimaker.Cura is legacy blacklisted
🟢 Searching for string ""
🟢 Searching for string ""
🟢 Total packages: 0
Win32Mica Error: win32 version 19045 is not supported
🟢 Starting winget search, winget on C:\Users\aabdi\AppData\Local\Programs\WingetUI\winget-cli\winget.exe...
🟡 package Entity Framework 6.1.3 Tools  for Visual… failed parsing, going for method 2...
Entity Framework 6.1.3 Tools  for Visual… {2A56910C-69C8-495D-8ED8-9080F0A14E58}     14.0.41103.0 85
🟡 package Update for  (KB2504637) failed parsing, going for method 2...
Update for  (KB2504637)                   {CFEF48A8-BFB8-3EAC-8BA5-DE4F8AA267CE}.KB… 1 85
🟢 Winget uninstallable packages search finished
🟢 Searching for string ""
🟢 Searching for string ""
🟢 Total packages: 338
🟢 Starting winget search, winget on C:\Users\aabdi\AppData\Local\Programs\WingetUI\winget-cli\winget.exe...
🟢 Winget search finished
🟠 Package Piriform.CCleaner.ProTrial is legacy blacklisted
🟠 Package Ultimaker.Cura is legacy blacklisted
🟢 Searching for string ""
🟢 Searching for string ""
🟢 Total packages: 0
Win32Mica Error: win32 version 19045 is not supported
🔵 Copying log to the clipboard...

Additional context

No other context; pretty straightforward.

@eidylon eidylon added the bug Something isn't working label May 5, 2023
@marticliment marticliment added this to the Details milestone May 5, 2023
marticliment added a commit that referenced this issue May 8, 2023
@marticliment marticliment removed this from the Details milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appearance bug Something isn't working ready-to-go
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants