Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Steam and MSStore aren't displayed in error message #561

Merged
merged 2 commits into from Dec 30, 2022
Merged

Fix: Steam and MSStore aren't displayed in error message #561

merged 2 commits into from Dec 30, 2022

Conversation

ppvnf
Copy link
Contributor

@ppvnf ppvnf commented Dec 30, 2022

instead of showing only "Local PC", using f-string allows "Steam" and "MSStore" as well. I'm not sure, though, if it would be better to have a custom message for MSStore

Captura de tela 2022-12-30 113644
change to winget and scoop
Captura de tela 2022-12-30 113625

@marticliment
Copy link
Owner

I would do _("Uninstallable [...] listed ad {0} can not be [...]").format(item.text(4)), so the string "Uninstallable [...] listed ad {0} can not be [...]" can be easily added to tolgee

@ppvnf
make easier adding to Tolgee
e9c7b63 
marticliment suggestion to make easier to add in Tolgee 

marticliment#561 (comment)
@ppvnf
Copy link
Contributor Author

ppvnf commented Dec 30, 2022

Done

@marticliment marticliment merged commit 2560029 into marticliment:main Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marticliment marticliment marticliment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ppvnf @marticliment