Code Update apply_versions.py #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os.path.join to join file paths, which is a more robust and platform-independent way to join paths than concatenating strings. The updated error message is more robust. The original error message did not convert the exception object to a string, so if the exception object did not have a __str__ method defined (which is unlikely but possible), the code would have crashed with a TypeError. By calling str(e), we ensure that we always have a string representation of the error, even if the exception object is not a standard Python exception.
Added checking if file is missing
marticliment
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.path.join to join file paths, which is a more robust and platform-independent way to join paths than concatenating strings.
The updated error message is more robust. The original error message did not convert the exception object to a string, so if the exception object did not have a str method defined (which is unlikely but possible), the code would have crashed with a TypeError. By calling str(e), we ensure that we always have a string representation of the error, even if the exception object is not a standard Python exception.
Added checking if file is missing.