Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly label social networks in the description reply #61

Closed
Nedlinin opened this issue Mar 30, 2020 · 1 comment
Closed

Properly label social networks in the description reply #61

Nedlinin opened this issue Mar 30, 2020 · 1 comment

Comments

@Nedlinin
Copy link
Collaborator

https://www.reddit.com/r/listentothis/comments/frnzfw/squid_sludge_experimental_rock_2020/flwrnku/

This contains

socials: bandcamp, discogs, free streaming, purchase for download, social network, social network, social network, soundcloud

as the reply. Should be fairly trivial to check the URL for containing facebook, twitter, instagram, etc and replace the text with the actual social network being linked to rather than forcing the user to click/hover each.
ghost pushed a commit that referenced this issue Apr 1, 2020
sanitizing markdown and getting social media names
1d0c864 
Haven't gotten around to test this but I think it should work. Would solve #61 and #62
@ghost ghost mentioned this issue Apr 1, 2020
Merged
martijnboers added a commit that referenced this issue Apr 2, 2020
@martijnboers
sanitizing markdown and getting social media names (#63)
a7a6e04 
* sanitizing markdown and getting social media names

Haven't gotten around to test this but I think it should work. Would solve #61 and #62

* Making flake happy

* Minor optimization by adding a break

* Rewrote as a single function

* A (poor) attempt to make flake happy

* Trying to make flake happy again also formatting

* Fixed unclosed parenthesis

* Properly labelling a function

* Add test for formatted network provider

* Update README

I think with the github outage it didn't save my latest commit so adding
this commit here to make sure the previous commit is added

Co-authored-by: Martijn Boers <martijn@plebian.nl>
@martijnboers
Copy link
Owner

Closed by #63

@martijnboers martijnboers mentioned this issue Apr 2, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nedlinin @martijnboers